001_disable_all_openwrt_packages

[stappers]

This ticket is to report something that looks strange to me.

I think that a '[ynm]' should become '\[ynm\]',
but I haven't checked deeply.

Elaboration is in the next comment
and a proposed, but untested, patch is in the comment there after.

[stappers]

Elaboration:

stappers@viggo:/usr/src/debwrt/openwrt/patches
$ cat 001_disable_all_openwrt_packages 
--- include/toplevel.mk.org	2010-01-02 00:28:44.000000000 +0100
+++ include/toplevel.mk	2010-01-02 00:14:07.000000000 +0100
@@ -49,6 +49,11 @@
 		f=tmp/.$${type}info; t=tmp/.config-$${type}.in; \
 		[ "$$t" -nt "$$f" ] || ./scripts/metadata.pl $${type}_config "$$f" > "$$t" || { rm -f "$$t"; echo "Failed to build $$t"; false; break; }; \
 	done
+	# DebWrt: we don't need to build any packages by default, so we disable them 
+	#         all. This allows us to have fine control over which packages we
+	#         want to build.
+	sed 's/default [ynm]/default n/g' tmp/.config-package.in > tmp/.config-package.in.new
+	mv tmp/.config-package.in.new tmp/.config-package.in
 	./scripts/metadata.pl package_mk tmp/.packageinfo > tmp/.packagedeps || { rm -f tmp/.packagedeps; false; }
 	touch $(TOPDIR)/tmp/.build
 
stappers@viggo:/usr/src/debwrt/openwrt/patches
$ echo 'default [ynm]'  # print
default [ynm]
stappers@viggo:/usr/src/debwrt/openwrt/patches
$ echo 'default [ynm]' | sed 's/default [ynm]/default n/g' # no change
default [ynm]
stappers@viggo:/usr/src/debwrt/openwrt/patches
$ echo 'default [ynm]' | sed 's/default \[ynm\]/default n/g' # YES, Modified!
default n
stappers@viggo:/usr/src/debwrt/openwrt/patches
$ 

[stappers]

The untested patch:

--- openwrt/patches/001_disable_all_openwrt_packages	(revision 140)
+++ openwrt/patches/001_disable_all_openwrt_packages	(working copy)
@@ -7,7 +7,7 @@
 +	# DebWrt: we don't need to build any packages by default, so we disable them 
 +	#         all. This allows us to have fine control over which packages we
 +	#         want to build.
-+	sed 's/default [ynm]/default n/g' tmp/.config-package.in > tmp/.config-package.in.new
++	sed 's/default \[ynm\]/default n/g' tmp/.config-package.in > tmp/.config-package.in.new
 +	mv tmp/.config-package.in.new tmp/.config-package.in
  	./scripts/metadata.pl package_mk tmp/.packageinfo > tmp/.packagedeps || { rm -f tmp/.packagedeps; false; }
  	touch $(TOPDIR)/tmp/.build

( will also be attached )

[stappers]

the untested patch

[amain]

expected input sample:

• default y
• default n
• default m

$ echo "default y" | sed 's/default \[ynm\]/default n/g'
default n

Effectively disabling all modules correctly. With [a-z] character classes can be specified in regexes.

[Tivaerebabs]

acquistare levitra generico

<a href= ​http://www.achetercialis20mgprix.fr/#combinaisoncialisdoxazosine >combinaison cialis doxazosine</a>

<a href= ​http://www.acheterkamagraenfrance.fr/#acheterkamagra >acheter kamagra</a>

<a href= ​http://www.cialispascherenfrance.fr/#cialismoinscherenpharmacie,paris >cialis moins cher en pharmacie, paris</a>

<a href= ​http://www.levitraprixenpharmacie.fr/#pharmacienenfrancelevitragenerique >pharmacien en france levitra generique</a>

<a href= ​http://www.viagraprixenfrance.fr/#viagraoucialis >viagra ou cialis</a>

propecia 1 mg costo

[Tivaerebabs]

viagra effetti collaterali pressione

<a href= ​http://www.viagrakaufenindeutschland.de/#viagrakaufenpernachnahme >viagra kaufen per nachnahme</a>

<a href= ​http://www.propeciakaufendeutschland.de/#propeciagenerika >propecia generika</a>

<a href= ​http://www.kamagraoraljellykaufendeutschland.de/#kamagrabestellendeutschland >kamagra bestellen deutschland</a>

<a href= ​http://www.levitrakaufenindeutschland.de/#levitrakaufenohnerezept >levitra kaufen ohne rezept</a>

<a href= ​http://www.cialiskaufendeutschland.de/#cialisohnerezeptforum >cialis ohne rezept forum</a>

levitra 5 mg